Before this patch, movetab() just switched positions of the selected tab with
the new position. This resulted in unexpected behaviour when „moving“ a tab over
one end of the list.
Now tabs are moved correctly by the specified amount of indizes.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Hi,
Simple patch for tabbed that prevents tabbed from killing a client that it
should no longer be managing due to an UnmapNotify event.
Add support for UnmapNotify; allows a window to map and unmap without
needing it to be destroyed.
Thanks,
Okan
Signed-off-by: Christoph Lohmann <20h@r-36.net>
- Run "tabbed xterm -into".
- Open a new tab using Ctrl+Shift+Enter, switch to it using Ctrl+Tab.
- Run "sleep 2; printf '\a'".
- Quickly change back to the first tab (c = 0) and wait for the second
one (c = 1) to get the urgency hint.
- Close the first tab using Ctrl+Q or Ctrl+D. This sets sel = 0 and c =
0, so focus() won't touch the urgency hint.
- Now, the urgency hint on the second tab has not been cleared. Open a
new tab to verify it.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
The default config will display all open tabs in dmenu. You can either select
one of them, or if you enter a string, that does not start with „0x“, tabbed
will open a new tab and run the command specified at tabbed-startup but append
the entered string to the command first.
With
tabbed -r 2 surf -e ''
you can hit Ctrl-T and either select an already opened tab or enter an URL,
which will be opened in a new tab with surf.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
This crops up whenever you just switched from tab # N+1 to tab # N
and close current tab. unmanage() first decreases lastsel
(so it becomes N) then erroneously tests it against sel and focuses first tab
instead. One can see that focus() would never set lastsel == sel,
so I took liberty to fix this annoying behaviour which happens to frequently
with newposition = 0 and npisrelative = True settings.
Signed-off-by: Christoph Lohmann <20h@r-36.net>
Ahoy,
the attached patch fixes a tiny issue with tabbed. When running it
without a command and having it run spawn(), it tried to execute its
window ID as a command. While most people probably don't have
executables called 341123 or the like in their path, I think that is not
exactly intended. The following patch fixes that:
From c7ade36f8ef6429546ad89bc9ab479fa44c4790a Mon Sep 17 00:00:00 2001
From: Gregor Best <gbe@ring0.de>
Date: Sun, 7 Jul 2013 20:36:06 +0200
Subject: [PATCH] Don't set cmd[0] to the window ID
Starting tabbed without a command sets cmd[0] to the window ID of
tabbed. This leads to funky errors such as "execvp: <ID> failed: no such
file or directory" when running spawn().
Signed-off-by: Gregor Best <gbe@ring0.de>
Signed-off-by: Christoph Lohmann <20h@r-36.net>
