From c0d40e6f97a388b04f1e89a3c26c04ee6324a6e5 Mon Sep 17 00:00:00 2001
From: "E. S" <the@rootless.one>
Date: Mon, 28 Apr 2025 14:53:59 +0300
Subject: [PATCH] deploy: clean up code

---
 deploy/build_common.sh | 25 +++++++------------------
 deploy/build_css.sh    | 22 +++++++++++-----------
 deploy/build_js.sh     |  8 ++++----
 3 files changed, 22 insertions(+), 33 deletions(-)

diff --git a/deploy/build_common.sh b/deploy/build_common.sh
index 9cd03fd..12d6fe9 100755
--- a/deploy/build_common.sh
+++ b/deploy/build_common.sh
@@ -19,7 +19,8 @@ die() {
 }
 
 usage() {
-    local code="$1"
+    code="$1"
+    [ -z "$code" ] && code=0
     cat <<EOF
 usage: $PROGNAME [OPTIONS]
 
@@ -28,28 +29,17 @@ Options:
     -i  input directory
     -h  show this help
 EOF
-    exit $code
+    exit "$code"
 }
 
 input_args() {
     [ -z "$1" ] && usage
-
     while [ $# -gt 0 ]; do
         case $1 in
-            -o)
-                OUTDIR="$2"
-                shift
-                ;;
-            -i)
-                INDIR="$2"
-                shift
-                ;;
-            -h)
-                usage
-                ;;
-            *)
-                die "unexpected argument: $1"
-                ;;
+            -o) OUTDIR="$2"; shift ;;
+            -i) INDIR="$2"; shift ;;
+            -h) usage ;;
+            *) die "unexpected argument: $1" ;;
         esac
         shift
     done
@@ -64,7 +54,6 @@ check_args() {
         error "input directory not specified"
         usage 1
     }
-
     if [ ! -d "$OUTDIR" ]; then
         mkdir "$OUTDIR"
     else
diff --git a/deploy/build_css.sh b/deploy/build_css.sh
index 91fedab..571f08e 100755
--- a/deploy/build_css.sh
+++ b/deploy/build_css.sh
@@ -3,14 +3,14 @@
 DIR=$(cd "$(dirname "$(readlink -f "$0")")" && pwd)
 ROOT="$(realpath "$DIR/../")"
 CLEANCSS="$ROOT"/node_modules/clean-css-cli/bin/cleancss
-. $DIR/build_common.sh
+. "$DIR/build_common.sh"
 
 build_scss() {
-    local entry_name="$1"
-    local theme="$2"
+    entry_name="$1"
+    theme="$2"
 
-    local input="$INDIR/entries/$entry_name/$theme.scss"
-    local output="$OUTDIR/$entry_name"
+    input="$INDIR/entries/$entry_name/$theme.scss"
+    output="$OUTDIR/$entry_name"
     [ "$theme" = "dark" ] && output="${output}_dark"
     output="${output}.css"
 
@@ -18,10 +18,10 @@ build_scss() {
 }
 
 cleancss() {
-    local entry_name="$1"
-    local theme="$2"
+    entry_name="$1"
+    theme="$2"
 
-    local file="$OUTDIR/$entry_name"
+    file="$OUTDIR/$entry_name"
     [ "$theme" = "dark" ] && file="${file}_dark"
     file="${file}.css"
 
@@ -31,9 +31,9 @@ cleancss() {
 }
 
 create_dark_patch() {
-    local entry_name="$1"
-    local light_file="$OUTDIR/$entry_name.css"
-    local dark_file="$OUTDIR/${entry_name}_dark.css"
+    entry_name="$1"
+    light_file="$OUTDIR/$entry_name.css"
+    dark_file="$OUTDIR/${entry_name}_dark.css"
 
     "$DIR"/gen_css_diff.js "$light_file" "$dark_file" > "$dark_file.diff"
     rm "$dark_file"
diff --git a/deploy/build_js.sh b/deploy/build_js.sh
index 22ff999..c1e951d 100755
--- a/deploy/build_js.sh
+++ b/deploy/build_js.sh
@@ -1,14 +1,14 @@
 #!/bin/sh
 
 DIR=$(cd "$(dirname "$(readlink -f "$0")")" && pwd)
-. $DIR/build_common.sh
+. "$DIR/build_common.sh"
 
 # suckless version of webpack
 # watch and learn, bitches!
 build_chunk() {
-    local name="$1"
-    local output="$OUTDIR/$name.js"
-    local not_first=0
+    name="$1"
+    output="$OUTDIR/$name.js"
+    not_first=0
     for file in "$INDIR/$name"/*.js; do
         # insert newline before out comment
         [ "$not_first" = "1" ] && echo "" >> "$output"